Repository navigation
Fix WinRT JavaScript runtime-class interface input typing - #208
Merged
leileizhang (lei9444) merged 3 commits intoOct 8, 2026
Merged
Conversation
Keep existing class overload dispatchers while retaining metadata-projected interface aliases as real methods so StorageFile and StorageFolder satisfy their interface input types. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Accept optional trailing commas and format the two existing macro calls required by hosted Rust 1.99. Generated native signatures and behavior are unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Mixed-language test coverageWorkflow status: ✅ Passed
|
Compare real filesystem paths rather than hosted runner short-name spellings, and canonicalize the consumer root so strict TypeScript sees one path identity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
shisan (qiutongMS)
approved these changes
Oct 8, 2026
leileizhang (lei9444)
deleted the
lei9444-fix-js-interface-input-typing
branch
October 8, 2026 08:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
StorageFileworks withFileIOat runtime, but strict TypeScript rejects it asIStorageFile.StorageFolderhas the same mismatch withIStorageFolder: classes merge overload names, while interfaces retain explicit aliases that the classes no longer expose.Fix
Preserve metadata-projected instance aliases during overload merging and emit them as real JavaScript methods with matching declarations. Each alias keeps its declaring interface, QI, vtable slot and conversions. Existing class overloads, standalone interfaces and
.as(...)views remain unchanged; existing public members take precedence on name collisions.This adds interface-compatible class methods rather than widening inputs to
anyor declaring methods that do not exist at runtime. No native ABI, Python or release changes.Verification
Supporting CI-only changes format existing test-hook macros and compare canonical file identities on Windows runners; they do not change production dispatch.